BAC-199: Padding #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianStraszak
requested changes
Jul 23, 2025
src/lib.rs
Outdated
| Ok(encrypt(&padded_message, recipient_pub_key)) | ||
| } | ||
|
|
||
| pub fn decrypt_padded(ciphertext_bytes: &[u8], recipient_priv_key: &PrivKey) -> Result<Vec<u8>> { |
There was a problem hiding this comment.
Can we rename this to decrypt_padded_unchecked and then add decrypt_padded which also takes padded_length as a parameter, and errs in case there is length mismatch? That I think would be a bit safer
This reverts commit c6c274c.
Collaborator
Author
|
Marcin-Radecki
approved these changes
Jul 28, 2025
Contributor
|
I guess with this PR, this repo can be made read-only? https://github.com/Cardinal-Cryptography/ecies-encryption-poc |
DamianStraszak
approved these changes
Jul 29, 2025
DamianStraszak
left a comment
DamianStraszak
left a comment
There was a problem hiding this comment.
Thank you for this. Super clean now and the TS is there 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.