Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@kroist
Copy link
Contributor

@kroist kroist commented May 22, 2025

No description provided.

@kroist kroist requested a review from obrok May 22, 2025 08:43
@github-actions
Copy link

📊 Coverage Report

📈 Total Coverage Summary

Type Covered Total Coverage
📝 Lines 1530 2155 🟠 70.99%
📄 Statements 1530 2155 🟠 70.99%
⚡ Functions 108 115 🟡 93.91%
🔀 Branches 265 275 🟡 96.36%

Coverage Legend

  • ✅ 100% Coverage
  • 🟡 80-99% Coverage
  • 🟠 50-79% Coverage
  • ❌ 0-49% Coverage

📁 File Coverage

📋 Detailed Coverage Report
File Lines Statements Functions Branches
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/deposit.ts 88.88% 88.88% 100% 85%
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/newAccount.ts 84.49% 84.49% 100% 78.94%
zkOS-monorepo/ts/shielder-sdk/src/actions/types.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/utils.ts 97.33% 97.33% 100% 90.9%
🟠 zkOS-monorepo/ts/shielder-sdk/src/actions/withdraw.ts 77.04% 77.04% 87.5% 100%
zkOS-monorepo/ts/shielder-sdk/src/chain/contract.ts 1.89% 1.89% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/chain/relayer.ts 31.7% 31.7% 33.33% 50%
zkOS-monorepo/ts/shielder-sdk/src/client/actions.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/client/client.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/client/factories.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/client/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/constants.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/errors.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/index.ts 0% 0% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/accountFactory.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/accountRegistry.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/accountStateSerde.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/idManager.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/localStateTransition.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/chainStateTransition.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/historyFetcher.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/synchronizer.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/tokenAccountFinder.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/storage/storageManager.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/storage/storageSchema.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/utils.ts 100% 100% 100% 100%

@github-actions
Copy link

Transaction NameMainCurrentDifference (%)
Deposit (size)20255202550.00000%
DepositERC20 (gas)17593661759390+0.00136%
DepositNative (gas)17412771741229-0.00276%
NewAccount (size)22867228670.00000%
NewAccountERC20 (gas)17932501793274+0.00134%
NewAccountNative (gas)19973481997264-0.00421%
Withdraw (size)21573215730.00000%
WithdrawERC20 (gas)18609151860843-0.00387%
WithdrawNative (gas)18607361860676-0.00322%

Copy link
Contributor

@obrok obrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you're going to figure out the encryption part at a later stage?

#[derive(Serialize, Deserialize)]
pub enum Request {
Ping,
CalculateReward { viewing_key_base64: String },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: This will need to be encrypted later, right?

Comment on lines +16 to +17
CalculateReward { reward: String },
Error { message: String },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: I was wondering what's better here... this generic Error variant or CalculateReward(Result<CalculateRewardResult, CalculateRewardError>) no strong opinions either way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants