Skip to content

Remove deprecated RequestAdapter #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

amiedes
Copy link

@amiedes amiedes commented Feb 10, 2022

Removed because it breaks Honeycomb default HTTP instrumentation (https://app.shortcut.com/cartoteam/story/208668/lds-api-honeycomb-https-instrumentation-is-broken) and this adapter is deprecated in the upstream repository.

More info:

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #208668: LDS API / Honeycomb HTTPs instrumentation is broken.

Copy link

@charly22 charly22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll merge this change while we wait the deprecated dependency be removed in the upstream

@charly22 charly22 merged commit f1c64c1 into master Feb 11, 2022
@charly22 charly22 deleted the bug/sc-208668/lds-api-honeycomb-https-instrumentation-is branch February 11, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants