Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in the tests, use .artifact.ts everywhere #271

Closed
mr-zwets opened this issue Feb 10, 2025 · 1 comment
Closed

in the tests, use .artifact.ts everywhere #271

mr-zwets opened this issue Feb 10, 2025 · 1 comment
Labels
refactor Internal refactoring tests Related to automated tests
Milestone
v0.11

Comments

@mr-zwets
Copy link
Member

mr-zwets commented Feb 10, 2025 •
edited
Loading

in the tests, let's use .artifact.ts everywhere instead of

import xArtifact from './fixture/x.json' with { type: 'json' }

this will improve the tyings when writing additional tests or when refactoring the current tests
@mr-zwets mr-zwets added the refactor Internal refactoring label Feb 10, 2025
@mr-zwets mr-zwets added this to the v0.11.1 milestone Feb 10, 2025
@mr-zwets mr-zwets changed the title in the tests, use .artfiact.ts everywhere in the tests, use .artifact.ts everywhere Feb 10, 2025
@mr-zwets mr-zwets added the tests Related to automated tests label Feb 11, 2025
@PHCitizen PHCitizen mentioned this issue Feb 24, 2025
Merged
@mr-zwets mr-zwets modified the milestones: v0.11.1, v0.11 Mar 2, 2025
@rkalis
Copy link
Member

rkalis commented Apr 11, 2025

This was resolved in @PHCitizen's PR #283

@rkalis rkalis closed this as completed Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Internal refactoring tests Related to automated tests
Projects
None yet
Milestone
v0.11
Development

No branches or pull requests
2 participants
@rkalis @mr-zwets