replace all .json to .artifact.ts #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PHCitizen
commented
Feb 24, 2025
| @@ -62,8 +65,7 @@ describe('Contract', () => { | |||
|
|
|||
| it('should create new TransferWithTimeout instance', () => { | |||
| const provider = new ElectrumNetworkProvider(Network.CHIPNET); | |||
| const constructorArgs = [placeholder(65), placeholder(65), 1000000n]; | |||
| const instance = new Contract(twtArtifact, constructorArgs, { provider }); | |||
| const instance = new Contract(twtArtifact, [placeholder(65), placeholder(65), 1000000n], { provider }); | |||
There was a problem hiding this comment.
I just notice now that adding as const will make the array as read-only, however passing it to Contract will error because it expect mutable array. I just inline it, or any other suggestion?
|
Thanks for the PR! Indeed However, after merging Kiok's branch into |
PHCitizen
force-pushed
the
refactor/to-artifact-ts
branch
from
bd0767f to
7466712
Compare
|
Thank you for this PR @PHCitizen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #271