Optimize package installation #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 1, 2019 13:04
… installation isn't an n log n problem. 2. Use a single Installer to facilitate Catrobat#1.
|
Thank you for the PR. :) What does your gradle command look like so that the same packages are installed multiple times? |
|
Not so much the command as that I have multiple emulators defined and the way the code is set up it installs:
* emulator1 image
* emulator1 image
* emulator2 image
* emulator1 image
* emulator2 image
* emulator3 image
etc. each new emulator causes every prior emulator image to also be reinstalled. There are more correct ways to fix it, but this also catches the case where you have multiple emulators that use the same image (ie., a phone and tablet, both on 23)
David W. Berry
[email protected]
… On Apr 3, 2019, at 14:25, Matthias Fuchs ***@***.***> wrote:
Thank you for the PR. :)
What does your gradle command look like so that the same packages are installed multiple times?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
mfuchs
suggested changes
Apr 7, 2019
| @@ -170,6 +172,13 @@ class EmulatorsPluginExtension { | |||
| this.defaultEmulator | |||
| } | |||
|
|
|||
| Installer getInstaller() { | |||
| if(installer == null) { | |||
There was a problem hiding this comment.
Please add a space after the if.
| packages = packages.grep { !installed.contains(it) } | ||
|
|
||
| // If there's no work left, exit early | ||
| if(packages.empty) { |
There was a problem hiding this comment.
Please add a space there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize package installation by tracking which packages have been installed (during this run) and not attempting to reinstall them. Quick way around the current n log n process.