PAINTROID-654 : Remove tests from exluded folders and fix issues #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakicelebi
force-pushed
the
PAINTROID-654
branch
2 times, most recently
from
157f0c3 to
53dcf5a
Compare
bakicelebi
force-pushed
the
PAINTROID-654
branch
from
53dcf5a to
2e985fb
Compare
Lenkomotive
reviewed
Oct 11, 2023
bakicelebi
force-pushed
the
PAINTROID-654
branch
from
2e985fb to
f158512
Compare
Lenkomotive
approved these changes
Nov 29, 2023
|
@bakicelebi Why is device info plus added? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAINTROID-654
Removed tests from excluded folders in analysis options
Added riverpod as dev dependency to remove warning
Fixed analysis issues in various tests
Fixed the deprecated warning in CI
Include the name of the Jira ticket in the PR’s title
Include a summary of the changes plus the relevant context
Choose the proper base branch (develop)
Confirm that the changes follow the project’s coding guidelines
Verify that the changes generate no compiler or linter warnings
Perform a self-review of the changes
Verify to commit no other files than the intentionally changed ones
Include reasonable and readable tests verifying the added or changed behavior
Confirm that new and existing unit tests pass locally
Check that the commits’ message style matches the project’s guideline
Stick to the project’s gitflow workflow
Verify that your changes do not have any conflicts with the base branch
After the PR, verify that all CI checks have passed
Post a message in the #paintroid Slack channel and ask for a code reviewer