-
Notifications
You must be signed in to change notification settings - Fork 22
[ENG-8975] Redirect addons support #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/pbs-25.04
Are you sure you want to change the base?
[ENG-8975] Redirect addons support #696
Conversation
|
Needs to be released in tandem with this GV feature: CenterForOpenScience/gravyvalet#335 |
|
@futa-ikeda Looks like there are some conflicts that need resolving. |
| label: 'settings.addons.categories.otherServices', | ||
| value: AddonCategory.EXTERNAL_REDIRECT_SERVICES, | ||
| }, | ||
| // TODO: add this after feature flag gravy_redirect is either turned on for everyone or removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be added in near future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be addressed once we have deployed this to production and have confirmed with our external partners that things are working as expected for them on the production environment. I will make a separate ticket in Jira to clean up this feature-flagging logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jira ticket to remove feature flag logic is ENG-9787
Purpose
Summary of Changes
gravy__redirectfeature flagScreenshot(s)
If you have the feature flag

gravy_redirectactive, you will see the option to view redirect services from GravyValet, otherwise this page will not look any differentWhen clicking into a redirect service's addon card, the Addons Terms page has been updated to show "Go to {ServiceName}" button, which should open a popup window that will take users to the URL shown at the bottom of the screen, as well as a link in the description that will take user to the same place in case the popup window is blocked

Side Effects
QA Notes