cpp mini example for demo #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellygr
reviewed
Mar 29, 2025
DEFI/CPP_mini/test/CPPMini.t.sol
Outdated
Comment on lines
77
to
78
| _actualB0 = token0.balanceOf(address(cpp)); | ||
| _actualB1 = token0.balanceOf(address(cpp)); |
There was a problem hiding this comment.
both token0?
where is the assertion?
There was a problem hiding this comment.
this is actually not used, thanks.
the call to:
invariant_reserve(); has the assert but it is commented out to demonstrate the fact that the bug is critical. I think I will separate it to two tests:
- show that the manual crafted one causes the violation to be violated
- show that the bug is critical
Co-authored-by: shellygr <[email protected]>
Co-authored-by: shellygr <[email protected]>
Co-authored-by: shellygr <[email protected]>
shellygr
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.