Remove unused test utils, GltfBuilder.js

[donmccurdy]

Description

While reviewing uses of glTF Pipeline in the CesiumJS codebase, I ran across GltfBuilder.js (a utility in the packages/engine/Specs/ directory). This file is currently unused, with its original use case (ModelOutlineLoader) removed by #10644 in 2022. My feeling is that it's easy enough to restore the file from version history if needed, and that it can't easily be tested/maintained in the meantime, and so could be removed for now.

If the original use case, from #8776, were coming up again tomorrow - another option would be to generate these test files with https://gltf-transform.dev (disclaimer: I'm the author of glTF Transform).

Issue number and link

• Followup to Replace glTF model implementation #10644

Testing plan

n/a, removing unused code.

Author checklist

• I have submitted a Contributor License Agreement
• I have added my name to CONTRIBUTORS.md
• I have updated CHANGES.md with a short summary of my change
• I have added or updated unit tests to ensure consistent code coverage
• I have updated the inline documentation, and included code examples where relevant
• I have performed a self-review of my code

PR Dependency Tree

• PR Remove unused test utils, GltfBuilder.js #13111 👈

This tree was auto-generated by Charcoal

[github-actions]

Thank you for the pull request, @donmccurdy!

✅ We can confirm we have a CLA on file for you.

[javagl]

I wasn't aware of this class, and have used a ... *clears throat*... "pragmatic approach" occasionally. This could have been avoided by using this class, but ... it doesn't seem to support textures (and even less extensions), so it would need some ... extensions.

More generally: Creating differently-flavored, small glTFs for the specs is something that we should do more extensively (another example where this could be useful). Maybe pulling in glTF-Transform as a dependency (for the specs) could streamline some of that.

[donmccurdy]

Yes, this is roughly the approach I've taken when generating test data for glTF Transform itself. Example generator here:

• https://github.com/donmccurdy/glTF-Transform/blob/main/packages/test-utils/src/create-torus-primitive.ts

Generally I think it's nice to have test assets generated at test time. As opposed to static test assets, where it can be easy to end up with test assets that we no longer fully understand or can't easily recreate.

[ggetz]

Thanks for the cleanup @donmccurdy!