Skip to content

Conversation

@kring
Copy link
Member

@kring kring commented Jan 9, 2026

Fixes #13065

This PR is a proof-of-concept (hence the draft status), but it appears to fix significantly reduce the problem and I don't think it should have any major side effects. Please see that issue for more details.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Thank you for the pull request, @kring!

✅ We can confirm we have a CLA on file for you.

@kring
Copy link
Member Author

kring commented Jan 9, 2026

One problem I just realized is that the new Math.round is inappropriate if the heights are stored in, for example, a Float32Array. That's the cause of the test failures I believe. I guess we need to check, and only round if the height is about to be truncated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heightmap terrain data visually sinks downwards when upsampled past its limits

2 participants