fix: check if existing outbound stream is open #534
Open
julienmalard wants to merge 6 commits intoChainSafe:masterfrom
Open
fix: check if existing outbound stream is open #534julienmalard wants to merge 6 commits intoChainSafe:masterfrom
julienmalard wants to merge 6 commits intoChainSafe:masterfrom
Conversation
julienmalard
changed the title
`status` is actually a property of `OutboundStream.rawStream`
`has` returns a boolean, not the stream. Use `get` instead.
Check not only if the stream exists but also if it is open in `directConnect`.
julienmalard
added a commit
to reseau-constellation/ipa
that referenced
this pull request
Nov 14, 2025
Author
|
I just updated this branch...any chance for approval of the workflow @wemeetagain @nazarhussain ? |
Member
|
CI build issue here for resolving @julienmalard @wemeetagain |
Author
|
Thanks @philknows ; I'm currently away from the office but will check within a week or so. |
Author
|
@philknows The currently failing test does not seem to be related to the changes I effectuated (32 todo items are causing linting to fail). Could you advise please? |
Member
|
@nazarhussain Can you take a quick look here at why pnpm lint is failing here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check before aborting the stream creation fixes an issue, especially common over WebRTC connections, where a previously opened stream (e.g., WS over relay) has already been closed and prevents further gossipsub messages from being passed between peers.
If I am not mistaken, this will solve libp2p/js-libp2p#2771.