Python fixes #1353
Merged
Python fixes #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWouters
commented
Sep 17, 2024
| @@ -1 +1 @@ | |||
| import chainlit as cl | |||
| import chainlit as cl # noqa: F401 | |||
There was a problem hiding this comment.
Perhaps this line can be removed entirely.
dokterbob
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Another banger, @EWouters, love the help on this cleanup.
If you could please add the type declarations in un-commented version and remove the related noqa statements, I'm good to merge it. Best to get these larger things in fast to prevent merge conflict.s
EWouters
force-pushed
the
python-fixes
branch
from
074f493
to
598f56b
Compare
EWouters
force-pushed
the
python-fixes
branch
from
598f56b
to
6212451
Compare
EWouters
force-pushed
the
python-fixes
branch
from
6212451
to
982155e
Compare
dokterbob
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First go-around of Python fixes with the Trunk linters. I'm trying to keep the PR's small to make them easier to review. The commits are in decreasing order of priority in my opinion. There are a some more linter issues remaining which I intend to submit an additional PR for.
Please let me know of any problems with these commits. Some changes may be opinionated.