Add pypi publishing workflow #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msherman64
reviewed
Apr 1, 2025
| @@ -1,5 +1,5 @@ | |||
| [metadata] | |||
| name = python-blazarclient | |||
| name = chameleon-blazarclient | |||
There was a problem hiding this comment.
Does this change the module names, for things that might import blazarclient
And I was trying to figure out what happens if you install both python-blazarclient and chameleon-blazarclient into the same venv
And I think pip will actually just partially overwrite one of them:
pypa/pip#4625
There was a problem hiding this comment.
well, all the unittests still pass, so I thinkfrom blazarclient import foo still works
msherman64
approved these changes
Apr 1, 2025
| @@ -1,5 +1,5 @@ | |||
| [metadata] | |||
| name = python-blazarclient | |||
| name = chameleon-blazarclient | |||
There was a problem hiding this comment.
well, all the unittests still pass, so I thinkfrom blazarclient import foo still works
|
any reason not to merge? |
Author
|
@msherman64 I was planning to merge this after #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.