Skip to content

Update plural.csv#157

Open
thecosmicskye wants to merge 1 commit intoCharaChorder:mainfrom
thecosmicskye:patch-2
Open

Update plural.csv#157
thecosmicskye wants to merge 1 commit intoCharaChorder:mainfrom
thecosmicskye:patch-2

Conversation

@thecosmicskye
Copy link
Copy Markdown
Contributor

added contractions

added contractions
@Theaninova
Copy link
Copy Markdown
Member

These changes I don't understand, there's and that's are not plural?

@thecosmicskye
Copy link
Copy Markdown
Contributor Author

thecosmicskye commented Jul 17, 2025

These changes I don't understand, there's and that's are not plural?

You're right, they're contractions, but right now, when using the plural operator, "there" goes to "theres" and "that" goes to "thats'. These are incorrect.

This change fixes that.

This is also in line with the other files. For example, https://github.com/CharaChorder/CCOS-firmware/blob/main/grammar/comparative.csv, is full of non-comparatives, meaning it is used generally as "+er"

IMO, the plural file should be treated the same way for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants