Skip to content

New charts and options #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

New charts and options #2470

wants to merge 45 commits into from

Conversation

@elisaBarindelli
Copy link

@elisaBarindelli elisaBarindelli commented May 24, 2017

New charts:

  • GearChart
  • DistribuitonBarChart

New options:

  • Rounded corners in BarCharts
  • Rounded corners in HorizontalBarCharts
  • Gradient fill for BarCharts

@thierryH91200
Copy link
Contributor

thierryH91200 commented May 25, 2017

what is this "GearChart" ??

@liuxuan30
Copy link
Member

liuxuan30 commented May 26, 2017 •
edited
Loading

Resolve the conflics first.. your master seems not synced for a long time. BTW, please post some screeshots for your chart, thanks!

Also, don't put too many features in one PR, make it hard to review.

Please put

Rounded corners in BarCharts
Rounded corners in HorizontalBarCharts
Gradient fill for BarCharts

to different PRs. Thank you for your involvement!

@liuxuan30 liuxuan30 requested a review from danielgindi May 26, 2017 01:23
@jjatie jjatie self-assigned this Jan 12, 2018
@jjatie jjatie added this to the Future milestone Jan 22, 2018
@jjatie
Copy link
Collaborator

jjatie commented Mar 15, 2018

@elisaBarindelli We greatly appreciate your work here. This PR is quite large as expected, but in an effort to make it a) more manageable for us, and b) more maintainable for you, please split it up into 3 PRs (one for each new chart and one for the bar chart additions).

In addition, please base your PRs off of branch 4.0.0 and target that branch too. I know this was a lot of work, and it would be a shame to lose it due to staleness. Thank you.

@elisaBarindelli
Copy link
Author

elisaBarindelli commented Sep 6, 2018

@jjatie I will try to split the PR in 3 smaller parts and I will also base them on branch 4.0.0. Thanks and keep up the good work! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielgindi danielgindi Awaiting requested review from danielgindi

Assignees

@jjatie jjatie

Labels

None yet

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

7 participants

@elisaBarindelli @thierryH91200 @liuxuan30 @jjatie @marcozabo @SalvoSwift21 @gscarrone