i18n(tr): improve Turkish translations and parity with EN #898
Conversation
- Fix terminology: Polish→Parlat, Precise→Kesin, Float window→Pencereyi Yüzdür, UNAUTHORIZED→Yetkisiz - Normalize URL wording (API URL’si), Enter/Shift hints - Improve clarity: context length message, security check wording - Add missing keys from EN (retry button hint, crop text setting) - Minor punctuation/consistency fixes Build & lint: PASS
Summary of ChangesHello @cenktekin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Turkish localization of the application by refining existing translations for improved clarity, consistency, and natural language use. It also incorporates translations for previously missing English keys, ensuring a more complete and user-friendly experience for Turkish speakers. All changes are confined to the localization file, with no impact on runtime logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughTranslation files across 13 supported languages are refactored to split context-length error messages into separate keys for reusability, and error handling logic is updated to display multi-line feedback to users instead of concatenated messages. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (10)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (8)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨Latest suggestions up to e9128de
Previous suggestions✅ Suggestions up to commit bea7e8f
|
|||||||||||||||||||||||
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the Turkish localization by refining terminology, enhancing clarity, standardizing wording, and adding missing translations. The changes demonstrate a good understanding of both the source text and Turkish language nuances. I have a couple of minor suggestions to further improve consistency and completeness, but overall, this is excellent work that will greatly benefit Turkish-speaking users.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/_locales/tr/main.json(9 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/_locales/**/main.json
📄 CodeRabbit inference engine (AGENTS.md)
Do not change localization keys; add keys only in
en/main.jsonand propagate values to other locales
Files:
src/_locales/tr/main.json
🔇 Additional comments (1)
src/_locales/tr/main.json (1)
15-163: Translation improvements look good overall.The terminology updates (Url → URL'si, UNAUTHORIZED → Yetkisiz, Polish → Parlat, Precise → Kesin, Float the Window → Pencereyi Yüzdür) improve clarity and parity with the English version. Message expansions (lines 50, 94, 106) add helpful user guidance. Capitalization and punctuation consistency throughout the file is solid.
…n- Remove non-EN key from TR locale\n- Set value of existing key to retry-button hint (matches EN mapping)
…e 'to avoid blocking' meaning
|
Applied minor suggestions: capitalized Enter/Shift in the stop-generating hint and restored ‘to avoid blocking’ for parity. Formatted, linted, build OK. Commit: dca858a |
There was a problem hiding this comment.
Pull request overview
This PR improves Turkish translations to enhance clarity, consistency, and parity with English source strings. It focuses on terminology refinement, standardized formatting conventions, and expanded error messaging.
Key Changes:
- Refined Turkish terminology for better clarity (e.g., "Polish" → "Parlat" for content polishing, "Precise" → "Kesin", "UNAUTHORIZED" → "Yetkisiz")
- Standardized technical terms and formatting (consistent "API URL'si", capitalized keyboard shortcuts like "Enter" and "Shift + Enter", "Token" instead of "Jeton")
- Added missing translation keys and expanded error messages with actionable guidance (context length exceeded message, retry button hint, "Crop Text" entry)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Align 'And refresh this page' translation with English source - Capitalize 'Token' in moonshot error message for consistency
|
@codex review |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
- Split 'Exceeded maximum context length' into separate error and action keys as requested. - Updated all 13 language locales to match this new structure to ensure consistency and prevent mixed-language error messages. - Reorganized 'Crop Text' setting to a more logical position (near conversation length settings) per review suggestion. - Fixed a translation mismatch in the Turkish locale for the 'retry button' instruction. - Applied code formatting across modified files.
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (6)
src/_locales/in/main.json (1)
1-164: Missing translation key for "Crop Text" setting.The English locale file includes a new key "Crop Text to ensure the input tokens do not exceed the model's limit" (line 109 in en/main.json), but this key is absent from the Indonesian locale. This key should be added to maintain parity with the English version.
src/_locales/de/main.json (1)
1-164: Missing translation key for "Crop Text" setting.The English locale includes "Crop Text to ensure the input tokens do not exceed the model's limit" (en/main.json line 109), which is missing from the German locale. Consider adding the German translation to maintain feature parity.
src/_locales/ja/main.json (1)
1-164: Missing "Crop Text" translation.The "Crop Text to ensure the input tokens do not exceed the model's limit" key (present in en/main.json line 109) is absent from the Japanese locale. Add the Japanese translation for completeness.
src/_locales/it/main.json (1)
1-164: Missing "Crop Text" translation.The Italian locale is missing the "Crop Text to ensure the input tokens do not exceed the model's limit" key that appears in the English locale (line 109). Please add the Italian translation.
src/_locales/es/main.json (1)
1-164: Missing "Crop Text" translation.The Spanish locale lacks the "Crop Text to ensure the input tokens do not exceed the model's limit" key found in the English locale (line 109). Add the Spanish translation to maintain feature parity.
src/_locales/ru/main.json (1)
1-164: Missing "Crop Text" translation.The Russian locale is missing the "Crop Text to ensure the input tokens do not exceed the model's limit" key present in the English locale (line 109). Add the Russian translation for consistency.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (15)
ICON_SYSTEM_ANALYSIS.mdsrc/_locales/de/main.jsonsrc/_locales/en/main.jsonsrc/_locales/es/main.jsonsrc/_locales/fr/main.jsonsrc/_locales/in/main.jsonsrc/_locales/it/main.jsonsrc/_locales/ja/main.jsonsrc/_locales/ko/main.jsonsrc/_locales/pt/main.jsonsrc/_locales/ru/main.jsonsrc/_locales/tr/main.jsonsrc/_locales/zh-hans/main.jsonsrc/_locales/zh-hant/main.jsonsrc/services/wrappers.mjs
🚧 Files skipped from review as they are similar to previous changes (1)
- src/_locales/tr/main.json
🧰 Additional context used
🧬 Code graph analysis (1)
src/services/wrappers.mjs (1)
src/components/ConversationCard/index.jsx (1)
port(59-59)
🔇 Additional comments (15)
src/_locales/in/main.json (1)
93-94: LGTM: Error message split implemented correctly.The split of the context length error into two separate keys follows the PR's broader i18n consistency update. The Indonesian translations are clear and appropriate.
src/_locales/de/main.json (1)
93-94: LGTM: Error message restructuring applied correctly.The German translations properly split the context length error message into two distinct keys, aligning with the broader localization consistency effort.
src/_locales/en/main.json (1)
93-94: LGTM: Error message refactoring implemented cleanly.The split of the context-length error into two keys ("Exceeded maximum context length" and "Please clear the conversation and try again") improves modularity and aligns with the PR's goal of clearer, more actionable error messaging.
src/_locales/ja/main.json (1)
93-94: LGTM: Japanese error message split is clean and accurate.The Japanese translations correctly implement the two-key error message pattern, with natural phrasing that maintains clarity for users.
src/_locales/it/main.json (1)
93-94: LGTM: Italian translations follow the new error message structure.The Italian locale properly implements the split error messaging pattern with appropriate translations.
src/_locales/es/main.json (1)
93-94: LGTM: Spanish error message refactoring is correct.The Spanish translations accurately split the context-length error into two keys, maintaining clear and actionable messaging for Spanish-speaking users.
src/_locales/zh-hans/main.json (2)
93-94: LGTM: Simplified Chinese error message split is well executed.The Simplified Chinese translations cleanly implement the two-key error message pattern with accurate and natural phrasing.
109-109: Good: "Crop Text" translation included.The Simplified Chinese locale correctly includes the translation for the new "Crop Text" setting. This locale is one of the few that has this translation—ensure other locales follow suit.
src/_locales/ru/main.json (1)
93-94: LGTM: Russian translations correctly implement the new structure.The Russian locale properly splits the context-length error message into two keys with accurate translations.
src/_locales/fr/main.json (1)
93-94: LGTM! French translations are clear and actionable.The split of the error message into a concise error statement (line 93) and separate guidance (line 94) improves clarity. The French translations are appropriate and align with the PR's objectives to provide more actionable error messages.
src/_locales/ko/main.json (1)
93-94: LGTM! Korean translations follow the improved error message structure.The changes correctly split the error message into a descriptive error (line 93) and actionable guidance (line 94), consistent with the improvements across other locales.
src/_locales/pt/main.json (1)
93-94: LGTM! Portuguese translations are clear and consistent.The error message split follows the same pattern as other locales, with appropriate Portuguese translations for both the error statement (line 93) and the guidance (line 94).
src/_locales/zh-hant/main.json (2)
93-94: LGTM! Traditional Chinese translations are accurate and consistent.The error message improvements are properly translated and follow the same pattern established across all other locales in this PR.
109-109: ✓ The "Crop Text" key is present and consistent across all locales.The key appears at line 109 in
en/main.json,tr/main.json, andzh-hant/main.jsonwith appropriate translations. The PR's objective to add this English key to the Turkish locale has been completed successfully.src/services/wrappers.mjs (1)
63-70: All locale files already include both translation keys—no action required.Verification confirms that all 13 locale files (de, en, es, fr, in, it, ja, ko, pt, ru, tr, zh-hans, zh-hant) contain both
"Exceeded maximum context length"and"Please clear the conversation and try again"keys. No runtime translation errors will occur.🔎 Optional: Consider using template literals for readability
- port.postMessage({ - error: - t('Exceeded maximum context length') + - '\n' + - t('Please clear the conversation and try again') + - '\n\n' + - err.message, - }) + port.postMessage({ + error: `${t('Exceeded maximum context length')} +${t('Please clear the conversation and try again')} + +${err.message}`, + })
2 participants
User description
Summary
Scope
Validation
Manual sanity checks
Notes
PR Type
Documentation
Description
Improve Turkish terminology consistency and clarity
Normalize URL and technical wording across translations
Expand error messages with actionable guidance
Add missing English keys to Turkish localization
Minor punctuation and wording refinements for consistency
Diagram Walkthrough
File Walkthrough
main.json
Turkish localization improvements and English paritysrc/_locales/tr/main.json
the Window" → "Pencereyi Yüzdür", "UNAUTHORIZED" → "Yetkisiz"
"Jeton"
consistency
button hint
not exceed the model's limit"
dek" → "Süresiz"
Summary by CodeRabbit
New Features
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.