feat: fail_on threshold option enabled #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#134
This PR introduces a new fail_on_threshold input for the KICS GitHub Action, allowing users to specify severity thresholds using natural operators (e.g., high>1,low>5). When set, fail_on_threshold takes precedence over fail_on and ignore_on_exit, and the workflow will only fail if a threshold is exceeded. This makes it easier to control workflow failures based on the number of issues found for each severity, providing more flexible and intuitive scan result handling. Documentation has been updated to reflect this behavior.
This can act as quality gate condition which each repo owners can set
Testing
Failure scenario
https://github.com/msandeep12/terraform-examples/actions/runs/16397596206
Success scenario
https://github.com/msandeep12/terraform-examples/actions/runs/16397524250