Skip to content

Conversation

@cx-andre-pereira
Copy link
Contributor

@cx-andre-pereira cx-andre-pereira commented Oct 23, 2025

Reason for Proposed Changes

  • Currently there is no query to ensure that a "google_sql_database_instance" resource with a "SQLSERVER" based "database_version" has the '3625'(trace log) flag set to "on".

  • Quoting CIS_Google_Cloud_Platform_Foundation_Benchmark_v4.0.0 page 259: "3625(trace log) Limits the amount of information returned to users who are not members of the sysadmin fixed server role, by masking the parameters of some error messages using '******'. Setting this in a Google Cloud flag for the instance allows for security through obscurity and prevents the disclosure of sensitive information, hence this is recommended to set this flag globally to on to prevent the flag having been left off, or changed by bad actors.

Proposed Changes

  • Implemented the missing query.

  • The query will flag for 4 separate instances : (all after ensuring "database_version" is SQLSERVER based (possible values list))

    • Missing the "settings" field
    • Missing the "settings.database_flags" field
    • Missing a definition for the "3625" flag on the "database_flags" field
    • Setting the "3625" flag to a value that is not "on" (default value is off)

Tenable reference

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added feature New feature query New query feature terraform Terraform query labels Oct 23, 2025
@github-actions
Copy link
Contributor

kics-logo

KICS version: v2.1.13

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-andre-pereira cx-andre-pereira marked this pull request as ready for review October 23, 2025 10:21
@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner October 23, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant