-
Notifications
You must be signed in to change notification settings - Fork 352
perf(engine): optimize Terraform parser with directory caching and LOC-based memory calculation #7864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
perf(engine): optimize Terraform parser with directory caching and LOC-based memory calculation #7864
Conversation
…ddition-workers
…ttps://github.com/Checkmarx/kics into AST-116333-refactor-terraform-variables-resolution
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21271469 | Triggered | Generic Password | 5fd3a69 | assets/queries/terraform/azure/unrestricted_sql_server_access/test/negative5.tf | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
cx-eduardo-semanas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cx-rui-araujo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cx-artur-ribeiro check my comment pls
| mergeMaps(variablesMap, variables) | ||
| } | ||
| } | ||
| cacheKey = currentPath + "|" + terraformVarsPath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the cache key is the full path, it can sometimes become quite large. Should this be a hash instead?
Please ask the rest of the team for their opinions








Reason for Proposed Changes
KICS experienced OOM errors when scanning large Terraform codebases due to:
Proposed Changes
I submit this contribution under the Apache-2.0 license.