Skip to content

Conversation

@tstites14
Copy link

Let me know if anything is messed up with this change, please.

@Clechay
Copy link

Clechay commented Nov 20, 2020

Assuming no changes in code itself are required it seems fine to me.
This is what changed in BC from 7.99.24.5 to 7.99.24.6, it seems to be worth testing whether EU-MJ-Engine works out of the box on 7.99.24.6 with just a version bump because changes in BC are not really related to engines or even energy at all (except for quarries).
BuildCraft/BuildCraft@7.99.24.5...7.99.24.6

@Clechay
Copy link

Clechay commented Nov 20, 2020

I've applied your changes together with #13 , compiled it (OpenJDK8 + Gradle 4.9) and everything worked just fine in following testing environment:

name ver
minecraft.jar 1.12.2
minecraft.jar 9.42
forge-1.12.2-14.23.5.2854.jar 8.0.99.99
forge-1.12.2-14.23.5.2854.jar 14.23.5.2854
buildcraft-all-7.99.24.6.jar 7.99.24.6
CodeChickenLib-1.12.2-3.2.3.358-universal.jar 3.2.3.358
EnderStorage-1.12.2-2.4.6.137-universal.jar 2.4.6.137
industrialcraft-2-2.8.220-ex112.jar 2.8.220-ex112
EnergyControl-1.12.2-0.1.8.jar 1.12.2-0.1.8
energymeters-1.12.2-1.0.2.jar 1.0.2
EU-MJ Engine-2.7.2.jar 2.7.2
ForgeMultipart-1.12.2-2.6.2.83-universal.jar 2.6.2.83
InventoryTweaks-1.63.jar 1.63+release.109.220f184
journeymap-1.12.2-5.7.1.jar 1.12.2-5.7.1
MrTJPCore-1.12.2-2.1.4.43-universal.jar 2.1.4.43
ProjectRed-1.12.2-4.9.4.120-Base.jar 4.9.4.120
ProjectRed-1.12.2-4.9.4.120-compat.jar 1.0
ProjectRed-1.12.2-4.9.4.120-integration.jar 4.9.4.120
ProjectRed-1.12.2-4.9.4.120-lighting.jar 4.9.4.120
railcraft-12.0.0.jar 12.0.0
rsgauges-1.12.2-1.2.4.jar 1.2.4

I believe it's perfectly ok to merge.
Here is my build I've used for testing:
build of EU-MJ Engine-pr11-pr13.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants