Fix update interval edge case, remove duplicate code and add better startup warning #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tual info to warning In the previous implementation (PR ChrisTitusTech#127), there was an edge case where a powershell update check will take place and a profile update check might not due to floating point vs int values (.Date vs without (L84 vs L125 in aforementioned PR)). Commonize the checks since no situation exists where one runs but the other does not. Add better dev-centered warning message since the previous warning was made to address the fact the profile has transitioned from update checks every launch to a periodic check, now that users are aware of it, we can notify them when the next update will occur rather than the fact it was just skipped. (Issue ChrisTitusTech#130) Signed-off-by: Anirudh Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.