feat: support protocolTimeout #271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dungnguyent8
force-pushed
the
feat/support-protocol-timeout
branch
from
491ae91 to
8a67125
Compare
OrKoN
force-pushed
the
feat/support-protocol-timeout
branch
from
8a67125 to
a3ffe2e
Compare
|
@Lightning00Blade I wonder if we should just bump the protocol timeout value or use Puppeteer's default instead of making it configurable? WDYT? |
|
I think using the default should be OK. We do set some timeouts high ourselves when emulation is enabled. |
pull bot
pushed a commit
to oogalieboogalie/chrome-devtools-mcp
that referenced
this pull request
Oct 8, 2025
AlinaVarkki
pushed a commit
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
--protocolTimeoutCLI option, allowing users to configure the timeout for Chrome DevTools Protocol operations.Key Changes:
README.md: Updated to document the new--protocolTimeoutCLI option.src/cli.ts: Added theprotocolTimeoutoption to the CLI argument parser.src/browser.ts: Modified browser connection and launch functions to accept and utilize theprotocolTimeoutvalue, defaulting to 10 seconds if not specified. A clarifying comment was added to theMcpLaunchOptionsinterface.src/main.ts: Integrated theprotocolTimeoutargument when connecting to or launching the browser.These changes enhance flexibility by enabling users to adjust the protocol timeout based on their specific needs, improving stability for operations that might require longer execution times.
Related issue:
