Addition of L4l7 device modules (DCNE-334) #739

shrsr · 2025-04-10T16:03:22Z

No description provided.

akinross · 2025-04-11T11:17:37Z

plugins/modules/aci_l4l7_concrete_device.py

+    aliases: [ concrete_device, concrete_device_name ]
+  vcenter_name:
+    description:
+    - The virtual center name on which the device is hosted in the L4-L7 device cluster.


what is the virtual center referring to? is this VMware VCenter?

Likely because vCenter is a product that solely belongs to VMware?

plugins/modules/aci_l4l7_logical_interface.py

akinross

LGTM

anvitha-jain

LGTM

gmicol

LGTM

lhercot · 2025-04-18T06:54:23Z

plugins/modules/aci_l4l7_concrete_interface.py

+  path_ep:
+    description:
+    - The path to the physical interface.
+    - For single ports, this is the port name, e.g. "eth1/15".
+    - For Port-channels and vPCs, this is the Interface Policy Group name.
+    type: str


I would move path_ep as an alias and have interface as the main attribute and interface_name and interface_policy_group and interface_policy_group_name as additional aliases.

lhercot · 2025-04-18T07:01:18Z

plugins/modules/aci_l4l7_concrete_interface_attach.py

+DOCUMENTATION = r"""
+---
+module: aci_l4l7_concrete_interface_attach
+short_description: Manage L4-L7 Concrete Interface Attach (vns:RsCIfAttN)


Suggested change

short_description: Manage L4-L7 Concrete Interface Attach (vns:RsCIfAttN)

short_description: Manage L4-L7 Concrete Interface Attachment (vns:RsCIfAttN)

lhercot · 2025-04-18T07:03:40Z

plugins/modules/aci_l4l7_device.py

+module: aci_l4l7_device
+short_description: Manage L4-L7 Devices (vns:LDevVip)
+description:
+- Manage Layer 4-7 (L4-L7) Devices.


Suggested change

- Manage Layer 4-7 (L4-L7) Devices.

- Manage Layer 4 to Layer 7 (L4-L7) Devices.

lhercot · 2025-04-18T07:05:25Z

plugins/modules/aci_l4l7_device.py

+    - The APIC defaults to C(single) when unset during creation.
+    type: str
+    choices: [ multi, single ]
+  dev_type:


swap attribute and aliases

lhercot · 2025-04-18T07:05:48Z

plugins/modules/aci_l4l7_device.py

+    type: str
+    choices: [ physical, virtual ]
+    aliases: [ device_type ]
+  func_type:


swap attribute and aliases

lhercot · 2025-04-18T07:08:26Z

plugins/modules/aci_l4l7_device.py

+    dev_type: physical
+    svc_type: adc
+    trunking: false
+    prom_mode: true


Suggested change

prom_mode: true

promiscuous_mode: true

lhercot · 2025-04-18T07:09:07Z

plugins/modules/aci_l4l7_logical_interface.py

+module: aci_l4l7_logical_interface
+short_description: Manage L4-L7 Logical Interface (vns:LIf)
+description:
+- Manage Layer 4-7 (L4-L7) Logical Interfaces.


Suggested change

- Manage Layer 4-7 (L4-L7) Logical Interfaces.

- Manage Layer 4 to Layer 7 (L4-L7) Logical Interfaces.

lhercot · 2025-04-18T07:09:26Z

plugins/modules/aci_l4l7_concrete_interface_attach.py

+module: aci_l4l7_concrete_interface_attach
+short_description: Manage L4-L7 Concrete Interface Attach (vns:RsCIfAttN)
+description:
+- Manage Layer 4-7 (L4-L7) Concrete Interface Attachment to Logical Interfaces.


Suggested change

- Manage Layer 4-7 (L4-L7) Concrete Interface Attachment to Logical Interfaces.

- Manage Layer 4 to Layer 7 (L4-L7) Concrete Interface Attachment to Logical Interfaces.

lhercot · 2025-04-18T07:09:39Z

plugins/modules/aci_l4l7_concrete_interface.py

+module: aci_l4l7_concrete_interface
+short_description: Manage L4-L7 Concrete Interfaces (vns:CIf)
+description:
+- Manage Layer 4-7 (L4-L7) Concrete Interfaces.


Suggested change

- Manage Layer 4-7 (L4-L7) Concrete Interfaces.

- Manage Layer 4 to Layer 7 (L4-L7) Concrete Interfaces.

lhercot · 2025-04-18T07:09:51Z

plugins/modules/aci_l4l7_concrete_device.py

+module: aci_l4l7_concrete_device
+short_description: Manage L4-L7 Concrete Devices (vns:CDev)
+description:
+- Manage Layer 4-7 (L4-L7) Concrete Devices.


Suggested change

- Manage Layer 4-7 (L4-L7) Concrete Devices.

- Manage Layer 4 to Layer 7 (L4-L7) Concrete Devices.

…st file

akinross

LGTM

sajagana · 2025-04-24T08:05:51Z

plugins/modules/aci_l4l7_concrete_interface.py

+  delegate_to: localhost
+
+- name: Query a concrete interface
+  cisco.aci.aci_l4l7_service_graph_template:


Suggested change

cisco.aci.aci_l4l7_service_graph_template:

cisco.aci.aci_l4l7_concrete_interface:

sajagana · 2025-04-24T08:06:18Z

plugins/modules/aci_l4l7_concrete_interface.py

+  register: query_result
+
+- name: Query all concrete interfaces
+  cisco.aci.aci_l4l7_service_graph_template:


Suggested change

cisco.aci.aci_l4l7_service_graph_template:

cisco.aci.aci_l4l7_concrete_interface:

…interface

akinross · 2025-04-25T15:01:32Z

plugins/modules/aci_l4l7_concrete_device.py

+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+
+# Copyright: (c) 2025, Tim Cragg (@timcragg)


your name in modules

akinross · 2025-04-25T15:01:51Z

plugins/modules/aci_l4l7_concrete_device.py

+  description: More information about the internal APIC class B(vns:CDev)
+  link: https://developer.cisco.com/docs/apic-mim-ref/
+author:
+- Tim Cragg (@timcragg)


your name in modules

akinross · 2025-04-25T15:02:10Z

tests/integration/targets/aci_l4l7_concrete_device/tasks/main.yml

@@ -0,0 +1,196 @@
+# Test code for the ACI modules
+# Copyright: (c) 2025, Tim Cragg (@timcragg)


your name in modules tests

akinross · 2025-04-25T15:02:47Z

plugins/modules/aci_l4l7_concrete_interface_attach.py

+
+DOCUMENTATION = r"""
+---
+module: aci_l4l7_concrete_interface_attach


why not name the module with full name?

Suggested change

module: aci_l4l7_concrete_interface_attach

module: aci_l4l7_concrete_interface_attachment

shrsr requested review from akinross, anvitha-jain, gmicol, lhercot, sajagana and samiib as code owners April 10, 2025 16:03

shrsr added the jira-sync label Apr 10, 2025

github-actions bot changed the title ~~Addition of L4l7 device modules~~ Addition of L4l7 device modules (DCNE-334) Apr 10, 2025

akinross requested changes Apr 11, 2025

View reviewed changes

shrsr requested a review from akinross April 11, 2025 17:18

akinross previously approved these changes Apr 14, 2025

View reviewed changes

anvitha-jain previously approved these changes Apr 14, 2025

View reviewed changes

gmicol previously approved these changes Apr 18, 2025

View reviewed changes

lhercot requested changes Apr 18, 2025

View reviewed changes

timcragg and others added 7 commits April 22, 2025 11:28

[minor_change] Addition of module aci_l4l7_device and its test file

5fd5812

[minor_change] Addition of module aci_l4l7_concrete_device and its te…

c57b3e3

…st file

[ignore] Removed aci_ip_sla_monitoring_policy module and its test file

15983a0

[ignore] Addition of concrete device modules and their test files

19da4e0

[ignore] Modified description of attributes in concrete device modules

e1e3b45

[ignore] Modified aci_l4l7_device modules to add appropriate aliases

434f044

[ignore] Added accidentally removed test file

Loading
Loading status checks…

ef3845b

shrsr dismissed stale reviews from gmicol, anvitha-jain, and akinross via ef3845b April 22, 2025 15:50

shrsr force-pushed the l4l7 branch from 5966b2a to ef3845b Compare April 22, 2025 15:50

shrsr added 2 commits April 22, 2025 11:52

[ignore] Modified description in aci_l4l7_concrete_interface_attach

7909d0b

[ignore] Modified required_if in aci_l4l7_device

Loading
Loading status checks…

72b9cdc

shrsr requested review from akinross, anvitha-jain and gmicol April 22, 2025 16:03

shrsr requested a review from lhercot April 22, 2025 16:03

akinross previously approved these changes Apr 23, 2025

View reviewed changes

sajagana requested changes Apr 24, 2025

View reviewed changes

[ignore] Modified the title in modules examples of aci_l4l7_concrete_…

Loading
Loading status checks…

967d062

…interface

shrsr dismissed akinross’s stale review via 967d062 April 24, 2025 19:04

shrsr requested review from sajagana and akinross April 24, 2025 19:04

akinross requested changes Apr 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addition of L4l7 device modules (DCNE-334) #739

Addition of L4l7 device modules (DCNE-334) #739

shrsr commented Apr 10, 2025

akinross Apr 11, 2025

shrsr Apr 11, 2025

akinross left a comment

anvitha-jain left a comment

gmicol left a comment

lhercot Apr 18, 2025

lhercot Apr 18, 2025

lhercot Apr 18, 2025

lhercot Apr 18, 2025

lhercot Apr 18, 2025

lhercot Apr 18, 2025

lhercot Apr 18, 2025

lhercot Apr 18, 2025

lhercot Apr 18, 2025

lhercot Apr 18, 2025

akinross left a comment

sajagana Apr 24, 2025

sajagana Apr 24, 2025

akinross Apr 25, 2025

akinross Apr 25, 2025

akinross Apr 25, 2025

akinross Apr 25, 2025

	short_description: Manage L4-L7 Concrete Interface Attach (vns:RsCIfAttN)
	short_description: Manage L4-L7 Concrete Interface Attachment (vns:RsCIfAttN)

	- Manage Layer 4-7 (L4-L7) Devices.
	- Manage Layer 4 to Layer 7 (L4-L7) Devices.

	- Manage Layer 4-7 (L4-L7) Logical Interfaces.
	- Manage Layer 4 to Layer 7 (L4-L7) Logical Interfaces.

	- Manage Layer 4-7 (L4-L7) Concrete Interface Attachment to Logical Interfaces.
	- Manage Layer 4 to Layer 7 (L4-L7) Concrete Interface Attachment to Logical Interfaces.

	- Manage Layer 4-7 (L4-L7) Concrete Devices.
	- Manage Layer 4 to Layer 7 (L4-L7) Concrete Devices.

	cisco.aci.aci_l4l7_service_graph_template:
	cisco.aci.aci_l4l7_concrete_interface:

		@@ -0,0 +1,196 @@
		# Test code for the ACI modules
		# Copyright: (c) 2025, Tim Cragg (@timcragg)

	module: aci_l4l7_concrete_interface_attach
	module: aci_l4l7_concrete_interface_attachment

Addition of L4l7 device modules (DCNE-334) #739

Are you sure you want to change the base?

Addition of L4l7 device modules (DCNE-334) #739

Conversation

shrsr commented Apr 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

anvitha-jain left a comment

Choose a reason for hiding this comment

gmicol left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment