Removed cloud site tasks from test files (DCNE-233) #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajagana
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
sajagana
changed the title
samiib
requested changes
Jan 14, 2025
sajagana
dismissed stale reviews from akinross, shrsr, and anvitha-jain
via
1025afe
sajagana
force-pushed
the
233_remove_could_tasks
branch
from
1025afe to
17502bd
Compare
akinross
requested changes
Jan 15, 2025
lhercot
requested changes
Apr 11, 2025
| @@ -364,7 +353,7 @@ | |||
| - non_existing_template is not changed | |||
| - non_existing_template.msg == "Provided template 'non_existing_template' not matching existing template(s){{':'}} Template1, Template2, TemplateL3out" | |||
| - non_existing_bd is not changed | |||
| - non_existing_bd.msg == "Provided BD 'BD1' not matching existing bd(s){{':'}} ansible_test_1" | |||
| - non_existing_bd.msg == "Provided BD 'BD1' not matching existing bd(s){{':'}} ansible_test_1" | |||
There was a problem hiding this comment.
I don't think that space is needed.
| cidr: 10.0.0.0/16 | ||
| subnet: 10.0.1.0/26 | ||
| private_link_label: 'PLL' | ||
|
|
||
| - name: Add new EPG service type parameters (for version greater than 3.3) |
There was a problem hiding this comment.
Remove all tasks related to Private Link Label (L587 to L648) as Private Link Label is a Cloud feature only
Comment on lines
972
to
975
| # Verify route_reachability argument when template_external_epg is associated with ansible_test site and | ||
| # template_external_epg type argument is set to cloud | ||
| - name: Ensure ANP exists | ||
| cisco.mso.mso_schema_template_anp: |
There was a problem hiding this comment.
Remove from L972 to L1061 as route_reachability is a Cloud only feature.
sajagana
dismissed stale reviews from shrsr, anvitha-jain, and gmicol
via
da26cdc
…e_graph module tasks and removed cloud site details from inventory.networking file
…sks from mso schema site related module test files
…ted tasks from mso_schema_site_external_epg, mso_schema_site_anp_epg
sajagana
force-pushed
the
233_remove_could_tasks
branch
from
da26cdc to
d0ccc78
Compare
anvitha-jain
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.