Skip to content

fixes "missing required argument" error and missing lock release #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erics465 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes "missing required argument" error and missing lock release #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd73149
fixes missing required argument error
Aug 15, 2019
e59fd8b
Adds missing lock release in case of errors when posting xml data
Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ucscsdk/ucscmethodfactory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,7 @@ def config_resolve_class_sorted(cookie, class_id, in_filter, in_size, in_hierarc
return xml_request


def config_resolve_classes(cookie, in_ids, in_return_count_only, in_hierarchical=YesOrNo.FALSE):
def config_resolve_classes(cookie, in_ids, in_return_count_only=None, in_hierarchical=YesOrNo.FALSE):
""" Auto-generated UCSC XML API Method. """
method = ExternalMethod("ConfigResolveClasses")

Expand Down
8 changes: 7 additions & 1 deletion ucscsdk/ucscsession.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,13 @@ def post_elem(self, elem, dme="central-mgr"):
self.dump_xml_request(elem)
xml_str = xc.to_xml_str(elem)

response_str = self.post_xml(xml_str, dme=dme)
response_str = ""
try:
response_str = self.post_xml(xml_str, dme=dme)
except:
self._tx_lock_release_conditional(elem)
raise

self.dump_xml_response(response_str)

try:
Expand Down