Open
Conversation
vvb
reviewed
Jul 26, 2017
| default_net="no", compression_type="included") | ||
| """ | ||
| from ucsmsdk.mometa.fabric.FabricVlan import FabricVlan | ||
| vlan = FabricVlan(parent_mo_or_dn=_base_dn, name=name, sharing=sharing, id=id, |
Member
There was a problem hiding this comment.
@ReignInChaos this is perfect for global vlan, we need to see how to use the same APIs for other vlans. May be we could provide the base_dn in vlan_create and default it to fabric/lan. that way, fabric specific vlans would also just work by providing a different base_dn argument value. This would need similar changes in vlan_get etc..
WDYT?
Author
There was a problem hiding this comment.
Great insight! That didn't even occur to me. I'll make updates accordingly.
Author
There was a problem hiding this comment.
Where is a good reference for the base_dn values? Paramerterizing base_dn is an option but I think abstracting that from the user of API would be more beneficial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added vlan functionality