Fix TypeError when ModelRunner initialized with health_check_port=None#947
Closed
Copilot wants to merge 2 commits intoPR-1160-inference-info-removal-for-local-runnersfrom
Closed
Fix TypeError when ModelRunner initialized with health_check_port=None#947Copilot wants to merge 2 commits intoPR-1160-inference-info-removal-for-local-runnersfrom
Copilot wants to merge 2 commits intoPR-1160-inference-info-removal-for-local-runnersfrom
Conversation
Co-authored-by: ackizilkale <10406054+ackizilkale@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update model configuration and inference compute validation
Fix TypeError when ModelRunner initialized with health_check_port=None
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tests in
test_runners.pyandtest_runners_proto.pyexplicitly passhealth_check_port=NonetoModelRunner, but the health server thread was started unconditionally, causingTypeError: 'NoneType' object cannot be interpreted as an integerduring socket binding.How
ModelRunner.__init__to only start health server thread whenhealth_check_port is not Noneis_ready,is_startup) regardless of server state, as these indicate model readiness independent of HTTP server presenceTests
health_check_port=Noneno longer encounter TypeErrorNotes
Union[int, None]- fix aligns implementation with signature💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.