Fix User.app() to return actual server data instead of empty values#954
Open
christineyu123 wants to merge 1 commit intomasterfrom
Open
Fix User.app() to return actual server data instead of empty values#954christineyu123 wants to merge 1 commit intomasterfrom
christineyu123 wants to merge 1 commit intomasterfrom
Conversation
Bug: User.app() was fetching app data from server but ignoring response.app and returning an App with only app_id and default/empty values. Fix: Use app.app_info.CopyFrom(response.app) to directly copy the protobuf from server, preserving all fields including enums (e.g., visibility=10). Test: Added test_get_app() to verify visibility and description are correctly retrieved from server. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
christineyu123
requested review from
ackizilkale,
luv-bansal and
nitinbhojwani
Minimum allowed line rate is |
ackizilkale
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: User.app() was fetching app data from server but ignoring response.app and returning an App with only app_id and default/empty values.
Fix: Use app.app_info.CopyFrom(response.app) to directly copy the protobuf from server, preserving all fields including enums (e.g., visibility=10).
Test: Added test_get_app() to verify visibility and description are correctly retrieved from server.