Fix duplicate health server startup in ModelRunner#955
Open
ackizilkale wants to merge 1 commit intomasterfrom
Open
Fix duplicate health server startup in ModelRunner#955ackizilkale wants to merge 1 commit intomasterfrom
ackizilkale wants to merge 1 commit intomasterfrom
Conversation
start_health_server_thread() was called twice on model load — once unconditionally and once inside the guard. The first call would bind the port successfully, causing the second call to fail with OSError: [Errno 98] Address already in use. Remove the unconditional call, keeping only the guarded one which also correctly respects health_check_port=None to disable the server.
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicate health server startup in ModelRunner
start_health_server_thread() was called twice on model load — once
unconditionally and once inside the
guard. The first call would bind the port successfully, causing the
second call to fail with OSError: [Errno 98] Address already in use.
Remove the unconditional call, keeping only the guarded one which
also correctly respects health_check_port=None to disable the server.