Skip to content

Comments

[EAGLE-7214 ]: Add configuration options for health check port in local-runner#957

Merged
patricklundquist merged 2 commits intomasterfrom
local-runner-health-port-10446615120966861997
Feb 21, 2026
Merged

[EAGLE-7214 ]: Add configuration options for health check port in local-runner#957
patricklundquist merged 2 commits intomasterfrom
local-runner-health-port-10446615120966861997

Conversation

@patricklundquist
Copy link
Contributor

  • Added --health-check-port, --disable-health-check, and --auto-find-health-check-port flags to clarifai model local-runner CLI command.
  • Updated ModelServer and ModelRunner to accept and respect the configured health check port.
  • Fixed a bug in ModelRunner where start_health_server_thread was called twice, causing "Address already in use" errors.
  • Implemented logic to automatically find an available port if requested.
  • Implemented logic to disable the health check server if port is set to -1 or 0.
  • Passed the health check port configuration to the Docker container when running in container mode.

- Added `--health-check-port`, `--disable-health-check`, and `--auto-find-health-check-port` flags to `clarifai model local-runner` CLI command.
- Updated `ModelServer` and `ModelRunner` to accept and respect the configured health check port.
- Fixed a bug in `ModelRunner` where `start_health_server_thread` was called twice, causing "Address already in use" errors.
- Implemented logic to automatically find an available port if requested.
- Implemented logic to disable the health check server if port is set to -1 or 0.
- Passed the health check port configuration to the Docker container when running in container mode.

Co-authored-by: patricklundquist <1460278+patricklundquist@users.noreply.github.com>
@ackizilkale
Copy link
Contributor

@patricklundquist why is this? So we can run multiple local runners on the same machine?

@ackizilkale
Copy link
Contributor

or was this port clashing with something

@patricklundquist
Copy link
Contributor Author

Port clashing

@patricklundquist
Copy link
Contributor Author

Also the multiple local runners case would be nice

@github-actions
Copy link

Code Coverage

Package Line Rate Health
clarifai 45%
clarifai.cli 68%
clarifai.cli.templates 46%
clarifai.client 65%
clarifai.client.auth 67%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.rag 0%
clarifai.runners 51%
clarifai.runners.models 64%
clarifai.runners.pipeline_steps 39%
clarifai.runners.pipelines 71%
clarifai.runners.utils 62%
clarifai.runners.utils.data_types 72%
clarifai.schema 100%
clarifai.urls 58%
clarifai.utils 60%
clarifai.utils.evaluation 16%
clarifai.workflows 95%
Summary 61% (10036 / 16321)

Minimum allowed line rate is 50%

@ackizilkale ackizilkale self-requested a review February 20, 2026 20:09
@patricklundquist patricklundquist merged commit e11c788 into master Feb 21, 2026
11 checks passed
@patricklundquist patricklundquist deleted the local-runner-health-port-10446615120966861997 branch February 21, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants