Update to Sail 0.3.3 #579
Update to Sail 0.3.3 #579
Conversation
|
|
There was a problem hiding this comment.
The files in sail-partitioned/ mostly duplicate the files in sail/.
May I ask you to create symbolic links where possible?
There was a problem hiding this comment.
Do you have an example to share?
Looking at clickhouse-parquet-partitioned, it's also a duplicate of the files in clickhouse-parquet:
There was a problem hiding this comment.
@rschu1ze, this does not matter, and we didn't use symlinks before. Copy-paste is ok.
| export TZ=Etc/UTC | ||
| sudo ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone | ||
|
|
||
| echo "Install Rust" |
There was a problem hiding this comment.
It would be nice if we could either use the Rust packages that ship with Ubuntu 24.10 (if not too old), or install at least in a local directory (not the user home directory).
There was a problem hiding this comment.
@rschu1ze I just copied what I saw in DataFusion:
https://github.com/ClickHouse/ClickBench/blob/main/datafusion/benchmark.sh#L3-L7
Also, It looks like modifying the user home directory was a recent addition in #496
export HOME=${HOME:=~}
There was a problem hiding this comment.
@rschu1ze, this does not matter, ClickBench runs in short-lived VMs.
|
@rschu1ze @alexey-milovidov Just checking in here |
Updated to Sail 0.3.3 and also added sail-partitioned.
Didn't update any results, wasn't sure if I'm supposed to do that or not.