Translations: add issue report banner to translation pages #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Blargian is attempting to deploy a commit to the ClickHouse Team on Vercel. A member of the Team first needs to authorize it. |
Blargian
changed the title
gingerwizard
requested changes
Mar 12, 2025
src/theme/DocItem/Layout/index.js
Outdated
|
|
||
| const locales = ['/ru/', '/jp/', '/zh/'] | ||
| let isEnglish = true; | ||
| console.log(location.pathname) |
| export default function DocItemLayout({children}) { | ||
| const docTOC = useDocTOC(); | ||
| const {metadata} = useDoc(); | ||
| const {editUrl} = metadata; | ||
|
|
||
| const location = useLocation(); |
There was a problem hiding this comment.
this can all be done much simpler, use the getDocusarusContext and you can get the locale. Just check its not en
There was a problem hiding this comment.
Changes pushed. The check with useLocation() is needed because we don't want to display it on this page, at least not until the mess of styling on this page is cleaned up.
gingerwizard
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist