Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new image component #3505

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

new image component #3505

wants to merge 2 commits into from

Conversation

gingerwizard
Copy link
Contributor

Summary

First attempt at an image component. Lazy loads all images and enforces consistent sizes and placement.

import chServer from '@site/static/images/deployment-modes/ch-server.png';

Image img={chServer} alt="ClickHouse Server" size="sm"/>
<Image img={chServer} alt="ClickHouse Server" size="sm"/>

sizes can be sm, md or lg.

Note that this is a draft as all images must be migrated for this to work - non migrated images won't render

Pending:

  • Shadow for lightmode
  • Rounded corners on top and bottom of screenshot - 4px.
  • Enforce min res on images (likely build check)
  • Enforce background color for light mode

Checklist

@gingerwizard gingerwizard requested a review from Blargian March 14, 2025 20:18
Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
clickhouse-docs-ru ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 8:19pm
clickhouse-docs-zh ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 8:19pm

@gingerwizard
Copy link
Contributor Author

md images need to be reduced to small if screen size is small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant