Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Documentation for CSP Private Links Setup #3513

Merged
merged 7 commits into from
Mar 19, 2025
Merged

Updated Documentation for CSP Private Links Setup #3513

merged 7 commits into from
Mar 19, 2025

Conversation

gkorolev
Copy link
Contributor

Updated Documentation for CSP Private Links Setup

  1. Added Disclaimers for CSP Configuration Steps
  2. Removed DNS Setup Recommendations
  3. Reviewed and Updated Configuration Steps
  4. Added "Scale plan" badge
  5. Removed mentions of production and development tiers

@gkorolev gkorolev requested a review from a team as a code owner March 18, 2025 02:54
@CLAassistant
Copy link

CLAassistant commented Mar 18, 2025 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Blargian
❌ gkorolev
You have signed the CLA already but the status is still pending? Let us recheck it.

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
clickhouse-docs-ru ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 8:19pm
clickhouse-docs-zh ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 8:19pm

tsolodov
tsolodov approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@tsolodov tsolodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Blargian
Blargian approved these changes Mar 18, 2025
View reviewed changes
@gkorolev gkorolev force-pushed the csp-private-links-update branch from 896fa35 to bdeee49 Compare March 18, 2025 20:19
@gkorolev gkorolev merged commit 93d4e45 into main Mar 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blargian Blargian Blargian approved these changes

@tsolodov tsolodov tsolodov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkorolev @CLAassistant @tsolodov @Blargian