-
Notifications
You must be signed in to change notification settings - Fork 107
feat: JWT auth, minimal ClickHouse Cloud CI #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
slvrtrn
wants to merge
6
commits into
main
Choose a base branch
from
jwt-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces JWT authentication via a new method on Client along with enhanced integration tests for ClickHouse Cloud and related CI configuration updates.
- Adds Client::with_access_token and updates authentication handling (credentials vs. JWT)
- Implements integration tests for JWT authentication and adjusts database creation to include a timestamp
- Refactors header handling and query/insert authentication while updating CI workflows and changelog
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tests/it/main.rs | Adds integration test documentation and environment-specific helpers |
tests/it/cloud_jwt.rs | Introduces JWT-specific integration tests |
src/watch.rs | Updates documentation for the fetch method in Watch |
src/query.rs | Refactors query header injection by delegating to with_authentication |
src/lib.rs | Implements Authentication enum and updates Client methods accordingly |
src/insert.rs | Uses with_authentication for header injection in insert operations |
src/headers.rs | Adds with_authentication helper for building request headers |
CHANGELOG.md | Documents the new JWT authentication feature |
.github/workflows/ci.yml | Revises CI configuration for supporting ClickHouse Cloud integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JWT auth is a new ClickHouse Cloud feature, introduced in January 2025.
Client::with_access_token
, slightly reworking the internal auth implementation.Client::with_user
andClient::with_password
will panic if called afterClient::with_access_token
(and vice versa).insert
andquery
will use appropriate headers based on the authentication method.Closes #183
Checklist