Skip to content

Conversation

koletzilla
Copy link
Contributor

@koletzilla koletzilla commented Aug 27, 2025

Summary

Related to #501

Fix missing yaml space

--> Running yamllint checks
.github/workflows/test_matrix.yml
  4:5       warning  too few spaces before comment  (comments)

It looks like Black wasn't excluding files from my virtual environment (.venv, the default in PyCharm) even when it's already in the exclude list. The fix makes black correctly process the exclude config.

Executing make check-black before:

((.venv) ) ➜  dbt-clickhouse git:(ClickHouse/small-lint-fixes) ✗ time make check-black
--> Running black checks
All done! ✨ 🍰 ✨
4495 files would be left unchanged.
make check-black  84.35s user 4.75s system 1025% cpu 8.692 total

after:

((.venv) ) ➜  dbt-clickhouse git:(ClickHouse/small-lint-fixes) ✗ time make check-black
--> Running black checks
All done! ✨ 🍰 ✨
85 files would be left unchanged.
make check-black  1.92s user 0.67s system 392% cpu 0.658 total

@koletzilla koletzilla requested a review from Copilot August 27, 2025 14:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses two linting configuration issues: fixing a YAML formatting warning and correcting Black's exclude configuration to properly filter files from virtual environments.

  • Fixed YAML spacing warning in GitHub workflow file
  • Corrected Black's exclude regex pattern by removing trailing pipe character
  • Updated Makefile to rely on pyproject.toml exclude configuration instead of command-line override

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Fixed Black's exclude regex pattern by removing trailing pipe character
Makefile Removed redundant --exclude parameter to use pyproject.toml configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@koletzilla koletzilla self-assigned this Aug 27, 2025
@BentsiLeviav BentsiLeviav self-requested a review August 28, 2025 14:45
@koletzilla koletzilla merged commit dcba7e4 into main Sep 3, 2025
2 of 42 checks passed
@koletzilla koletzilla deleted the ClickHouse/small-lint-fixes branch September 4, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant