forked from google/oss-fuzz
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump nokogiri from 1.12.5 to 1.14.3 in /docs #1
Open
dependabot
wants to merge
1
commit into
master
Choose a base branch
from
dependabot/bundler/docs/nokogiri-1.14.3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.5 to 1.14.3. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.12.5...v1.14.3) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
yakov-olkhovskiy
pushed a commit
that referenced
this pull request
Mar 11, 2025
Fix build error https://oss-fuzz-build-logs.storage.googleapis.com/log-17235690-03af-4f88-a2c8-1f7203f4695c.txt ```Step #1: Step 3/4 : COPY build.sh *.dict $SRC Step #1: When using COPY with more than one source file, the destination must be a directory and end with a / Finished Step #1 ``` @AdamKorcz
yakov-olkhovskiy
pushed a commit
that referenced
this pull request
Mar 11, 2025
- OSS-Fuzz builds are failing after pigweed was rebased in project-chip/connectedhomeip#35644 - One of the failures is related to pigweed becoming incompatible with python <3.9. Such as using subscript notation in the type hints. - Fix: Base images in OSS-Fuzz use python 3.8, This PR aims to force the usage of python3.10 instead ### Example Error ``` Step #1: Traceback (most recent call last): Step #1: File "../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py", line 38, in <module> Step #1: import gn_resolver # type: ignore Step #1: File "/src/connectedhomeip/third_party/pigweed/repo/pw_build/py/pw_build/gn_resolver.py", line 319, in <module> Step #1: _Actions = Iterator[tuple[_ArgAction, str]] Step #1: TypeError: 'type' object is not subscriptable Step #1: [137/1234] ln -f ../../third_party/pigweed/repo/pw_thread/pw_thread_protos/thread_snapshot_service.proto ```
yakov-olkhovskiy
pushed a commit
that referenced
this pull request
Mar 11, 2025
Fixes https://issues.oss-fuzz.com/issues/380676570 Excerpt: ``` Step #1: Step 5/13 : RUN git clone --depth 1 https://github.com/guidovranken/cryptofuzz Step #1: ---> Running in def8cd621b2d Step #1: �[91mCloning into 'cryptofuzz'... Step #1: �[0m�[91mfatal: could not read Username for 'https://github.com': No such device or address Step #1: The command '/bin/sh -c git clone --depth 1 https://github.com/guidovranken/cryptofuzz' returned a non-zero code: 128 Finished Step #1 ERROR ``` This is a clean removal, which can be reverted in the future, or reworked. For now, go ahead with the removal, to unbreak the build. Co-authored-by: MarcoFalke <[email protected]>
yakov-olkhovskiy
pushed a commit
that referenced
this pull request
Mar 11, 2025
Fixes several issues in the build which have been breaking the runtime code coverage collection since at least 2024-11-24. ### Key Changes: - Upgraded Node.js to the latest LTS release via the base image `install_javascriot.sh` script for compatibility with the upstream project's requirements. - Refined the build commands to prefer the upstream project's documentation. - Adjusted compiler flags to ensure only the executable fuzzing harness is placed in the `$OUT` directory so unnecessary build artifacts can't break anything in unexpected ways. ### Impact: - Resolves the broken coverage collection. - Marginally improves overall build times (see note below.) --- #### Note Nodejs Install Script Slowdowns The Dockerfile, both before and after this PR, uses a script hosted by https://deb.nodesource\.com to install a more recent version of Nodejs than the (extremely) old version available in the container by default. That has been working just fine, however while I was reviewing the build logs I noticed the install script prints a warning about the deprecation of this node 14 version, but more importantly: It deliberately sleeps for 80 seconds after printing the warnings, halting the build before continuing. Unfortunately this is not easy to spot when reviewing the raw log directly: https://oss-fuzz-build-logs.storage.googleapis.com/log-fdce3d72-fe01-4a10-9f84-98617dc5110b.txt It is a bit easier in the build status dashboard though: https://oss-fuzz-build-logs.storage.googleapis.com/index.html#llhttp See below: <details><summary>Log excerpt</summary> ```sh Step #1: ---> 92c0ffa5f35b Step #1: Step 3/8 : RUN curl -sL https://deb.nodesource.com/setup_14.x -o nodesource_setup.sh Step #1: ---> Running in 2337f2ad0189 Step #1: Removing intermediate container 2337f2ad0189 Step #1: ---> 4612ae8ce782 Step #1: Step 4/8 : RUN bash nodesource_setup.sh Step #1: ---> Running in e7a6477832e8 Step #1: Step #1: ================================================================================ Step #1: ================================================================================ Step #1: Step #1: DEPRECATION WARNING Step #1: Step #1: Node.js 14.x is no longer actively supported! Step #1: Step #1: You will not receive security or critical stability updates for this version. Step #1: Step #1: You should migrate to a supported version of Node.js as soon as possible. Step #1: Use the installation script that corresponds to the version of Node.js you Step #1: wish to install. e.g. Step #1: Step #1: * https://deb.nodesource.com/setup_16.x — Node.js 16 "Gallium" Step #1: * https://deb.nodesource.com/setup_18.x — Node.js 18 LTS "Hydrogen" (recommended) Step #1: * https://deb.nodesource.com/setup_19.x — Node.js 19 "Nineteen" Step #1: * https://deb.nodesource.com/setup_20.x — Node.js 20 "Iron" (current) Step #1: Step #1: Please see https://github.com/nodejs/Release for details about which Step #1: version may be appropriate for you. Step #1: Step #1: The NodeSource Node.js distributions repository contains Step #1: information both about supported versions of Node.js and supported Linux Step #1: distributions. To learn more about usage, see the repository: Step #1: https://github.com/nodesource/distributions Step #1: Step #1: ================================================================================ Step #1: ================================================================================ Step #1: Step #1: Continuing in 20 seconds ... Step #1: Step #1: Step #1: ================================================================================ Step #1: ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ Step #1: ================================================================================ Step #1: Step #1: SCRIPT DEPRECATION WARNING Step #1: Step #1: Step #1: This script, located at https://deb.nodesource.com/setup_X, used to Step #1: install Node.js is deprecated now and will eventually be made inactive. Step #1: Step #1: Please visit the NodeSource distributions Github and follow the Step #1: instructions to migrate your repo. Step #1: https://github.com/nodesource/distributions Step #1: Step #1: The NodeSource Node.js Linux distributions GitHub repository contains Step #1: information about which versions of Node.js and which Linux distributions Step #1: are supported and how to install it. Step #1: https://github.com/nodesource/distributions Step #1: Step #1: Step #1: SCRIPT DEPRECATION WARNING Step #1: Step #1: ================================================================================ Step #1: ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ Step #1: ================================================================================ Step #1: Step #1: TO AVOID THIS WAIT MIGRATE THE SCRIPT Step #1: Continuing in 60 seconds (press Ctrl-C to abort) ... Step #1: Step #1: Step #1: ## Installing the NodeSource Node.js 14.x repo... Step #1: Step #1: Step #1: ## Populating apt-get cache... Step #1: Step #1: + apt-get update Step #1: Hit:1 http://securi ``` </details>
yakov-olkhovskiy
pushed a commit
that referenced
this pull request
Mar 11, 2025
…3082) //python/dist currently does not build with bzlmod, since we don't support system_python in bzlmod yet. ``` Skipping '//python/dist:binary_wheel': error loading package 'python/dist': Unable to find package for @@[unknown repo 'system_python' requested from @@]//:version.bzl: The repository '@@[unknown repo 'system_python' requested from @@]' could not be resolved: No repository visible as '@system_python' from main repository. Step #1: �[0m�[91mERROR: error loading package 'python/dist': Unable to find package for @@[unknown repo 'system_python' requested from @@]//:version.bzl: The repository '@@[unknown repo 'system_python' requested from @@]' could not be resolved: No repository visible as '@system_python' from main repository. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps nokogiri from 1.12.5 to 1.14.3.
Release notes
Sourced from nokogiri's releases.
... (truncated)
Changelog
Sourced from nokogiri's changelog.
... (truncated)
Commits
e8d2f4a
version bump to v1.14.359fbc7b
doc: update CHANGELOG for v1.14.3347eacb
Merge pull request #2852 from sparklemotion/flavorjones-libxml2-2.10.4-backport36b0b33
dep: update libxml2 to 2.10.4 from 2.10.3ac83e6e
test: update behavior of namespaces in HTML42cf4996
test: make default GC behavior "normal"1580121
version bump to v1.14.25309477
Merge pull request #2791 from sparklemotion/2784-encoding-empty-strings-v1.14.x975ae49
doc: update CHANGELOGf13cdb4
fix: empty node set serialization when document encoding is nilDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.