chore: remove stdout/stderr pipe to /dev/null so users can see error logs during VM provisioning#48
Open
kurnoolsaketh wants to merge 2 commits intomainfrom
Open
chore: remove stdout/stderr pipe to /dev/null so users can see error logs during VM provisioning#48kurnoolsaketh wants to merge 2 commits intomainfrom
kurnoolsaketh wants to merge 2 commits intomainfrom
Conversation
kurnoolsaketh
changed the title
Contributor
|
i think a better way might be to log this to a log file because of fact that the vm spawn will detach pid etc |
Redirect the detached `tart run` daemon's stderr to ~/.config/tachikoma/logs/tart-run-<vm>.log so users can diagnose boot failures. Falls back to /dev/null if the log file can't be created. - Boot timeout error now includes the log path as a diagnostic hint - `tachikoma destroy` cleans up the log file
kurnoolsaketh
commented
Apr 7, 2026
| @@ -100,7 +108,15 @@ impl TartRunner for RealTartRunner { | |||
| cmd.args(&args_ref); | |||
| cmd.stdin(Stdio::null()); | |||
| cmd.stdout(Stdio::null()); | |||
Collaborator
Author
There was a problem hiding this comment.
@motsc what's your thinking for suppressing stdout? Noisy?
Contributor
There was a problem hiding this comment.
@kurnoolsaketh ah yes, so stdout from tart run is mostly VM lifecycle noise that would get interleaved with tachikoma's own output since this is a detached daemon. stderr is the useful stuff, so that's the one we capture to the log file.
motsc
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says