Skip to content

Conversation

GMartinez-Sisti
Copy link
Member

Why

  • Code inside github workflows is not linted and hard to read
  • The current logic doesn't cleanup all the ClickHouse cloud instances

What

  • Move bash scripts to files
  • Use bash arrays
  • Change endsWith to contains when removing test ClickHouse cloud instances

@GMartinez-Sisti GMartinez-Sisti self-assigned this Sep 1, 2025
@GMartinez-Sisti
Copy link
Member Author

/test development

@GMartinez-Sisti
Copy link
Member Author

/test development

@GMartinez-Sisti
Copy link
Member Author

/test development

@GMartinez-Sisti
Copy link
Member Author

/test development

@GMartinez-Sisti GMartinez-Sisti marked this pull request as ready for review September 2, 2025 09:36
@GMartinez-Sisti GMartinez-Sisti requested a review from a team as a code owner September 2, 2025 09:36
@GMartinez-Sisti GMartinez-Sisti changed the title chore(cleanup): move to script files chore(cleanup): move scripts to files Sep 2, 2025
@GMartinez-Sisti GMartinez-Sisti merged commit 163c366 into main Sep 2, 2025
5 checks passed
@GMartinez-Sisti GMartinez-Sisti deleted the fix-cleanup branch September 2, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants