Skip to content

add helper to return NSMenuItem.keyCombo #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add helper to return NSMenuItem.keyCombo #68

wants to merge 3 commits into from

Conversation

@DivineDominion
Copy link
Contributor

@DivineDominion DivineDominion commented Oct 31, 2020 •
edited
Loading

Requires Clipy/Sauce#35 to work
Closes Clipy/Sauce#32

  • update Sauce dependency to a new version where NSMenuItem.key is supported.
  • fix key code localization

@DivineDominion DivineDominion changed the title add helper to return NSMenuItem.keyCombo [WIP] add helper to return NSMenuItem.keyCombo Oct 31, 2020
@DivineDominion DivineDominion marked this pull request as draft October 31, 2020 12:30
@DivineDominion DivineDominion changed the title [WIP] add helper to return NSMenuItem.keyCombo add helper to return NSMenuItem.keyCombo Apr 12, 2021
@DivineDominion DivineDominion marked this pull request as ready for review April 12, 2021 07:51
@DivineDominion
Copy link
Contributor Author

DivineDominion commented Apr 12, 2021

@Econa77
With Sauce 2.2, I think the extension is ready to go. The "localization" issue of non-ASCII keys in shortcuts is not affecting the functionality currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support conversion from NSMenuItem.keyEquivalent to Sauce.Key

1 participant

@DivineDominion