This repository was archived by the owner on Jul 6, 2020. It is now read-only.
Open
Conversation
…into auth-guards
Contributor
Author
|
@Sanji515 Please take a look |
Contributor
Author
| import {ResetPasswordComponent} from './components/auth/reset-password/reset-password.component'; | ||
| import {ResetPasswordConfirmComponent} from './components/auth/reset-password-confirm/reset-password-confirm.component'; | ||
|
|
||
| import { AuthGuard } from './guards/auth-guard.service'; |
Member
There was a problem hiding this comment.
Can we have a better name: Authentication/authorization?
Contributor
Author
There was a problem hiding this comment.
That is normal convention
| return true; | ||
| } | ||
|
|
||
| const tree: UrlTree = this.router.parseUrl(routePath); |
Member
There was a problem hiding this comment.
I am not sure how this will help. I think UrlTree was introduced as return type from Angular 7 version.
Isn't it we can do this as well simply:
return isAuthenticated
?
Contributor
Author
There was a problem hiding this comment.
We can't because it will behave the same way as above
Contributor
Author
There was a problem hiding this comment.
Check out the GIF in the PR description. You will see the difference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # #271
Changes proposed in this pull request:
Previously:
Currently: