Fixing expired cert generation #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the addition of the new auth method I forgot to also reset the certgentime. This PR fixes this and add a test case so that we dont regress
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where certificate expiration times were not being properly extracted from JWT tokens, causing generated certificates to have incorrect expiry dates. The fix adds the missing assignment of CertNotAfter from the JWT and updates the backwards compatibility logic accordingly, along with test coverage to prevent regression.
- Added missing
CertNotAfterextraction from JWT tokens in authentication flow - Updated backwards compatibility check to properly handle the newly extracted field
- Added test validation to ensure generated certificates have valid time ranges
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/keymasterd/jwt.go | Fixed missing CertNotAfter assignment from JWT and updated backwards compatibility check from zero-value to time comparison |
| cmd/keymasterd/certgen.go | Enhanced debug logging to include full authData structure for troubleshooting |
| cmd/keymasterd/main_test.go | Added certificate validity time checks to test generated X.509 certificates have proper NotBefore and NotAfter values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the addition of the new auth method I forgot to also reset the certgentime.
This PR fixes this and add a test case so that we dont regress