Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(processor): replace filepath.Glob with doublestar.Glob for enhanced pattern matching #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BraveY
Copy link

@BraveY BraveY commented Mar 3, 2025

  • Replaced filepath.Glob with doublestar.Glob to support advanced glob patterns (e.g., **/*.py for recursive matching).

@BraveY BraveY force-pushed the feat-global-pattern branch from 56e79e1 to 927a10c Compare March 3, 2025 12:36
gaius-qi
gaius-qi previously approved these changes Mar 3, 2025
Copy link
Contributor

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yang Kaiyong added 2 commits March 4, 2025 10:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…nhanced pattern matching

- Replaced `filepath.Glob` with `doublestar.Glob` to support advanced glob patterns (e.g., `**/*.py` for recursive matching).

Signed-off-by: Yang Kaiyong <[email protected]>
…delfile

Added a detailed explanation of the unix-like glob path pattern.

Signed-off-by: Yang Kaiyong <[email protected]>
@BraveY BraveY force-pushed the feat-global-pattern branch from decb6f8 to ea5b98e Compare March 4, 2025 02:09
@chlins
Copy link
Contributor

chlins commented Mar 4, 2025

Currently, the glob path in the standard library is based on the standard implementation, and most language implementations are relatively uniform. While doublestar introduces convenience, it also introduces additional interpretation costs for users. So let's hold off for now and merge when there are similar requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants