Apply find_* function refactorings #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future commits will continue to get rid of uses of the global config variables. Some of those uses involve these macros, so we need a version of them that takes a conf argument as well. This commit just temporarily renames those macros so not every caller has to change. A later commit can introduce three argument versions of these macros, and then we can move callers in several commits. When all are moved, these renamed versions can go away.
These take an additional argument that is the config object. Nothing uses these at the moment - I'm going to move callers from the old renamed versions to these over a bunch of commits.
...as well as functions that call it. Also, change the site argument to be const. Co-authored-by: Jan Pokorný <[email protected]>
...as well as functions that call it. Co-authored-by: Jan Pokorný <[email protected]>
...as well as functions that call it. Also, mark _find_myself as static and remove the unnecessary function prototype for it. Co-authored-by: Jan Pokorný <[email protected]>
jfriesse
approved these changes
Aug 7, 2024
No problem, will do. I'd actually kind of forgotten too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next batch of refactorings from PR #82, though there are a couple differences from what's in those patches:
Note the FOREACH_NODE -> _FOREACH_NODE stuff. Basically, I renamed it and added a new version that takes an additional config pointer argument so I don't have to update all callers everywhere at once, along with all their callers, and so on.
These patches built, but would crash because message_recv has a new parameter, but that function is only ever indirectly called through function pointers, and the use of those pointers did not pass the config pointer. So, various other places had to get that argument added. I did not check very hard to see how this gets handled in the original PR in later patches.
I added a function pointer type to simplify having to deal with the above.