Skip to content

OCPBUGS-64765: add -a option to crictl ps #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fonta-rh wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

OCPBUGS-64765: add -a option to crictl ps #2112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3caa03f
add -a option to crictl ps
fonta-rh Dec 4, 2025
5ecf85c
Update comment
fonta-rh Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions heartbeat/podman-etcd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,8 @@ archive_data_folder()

etcd_pod_container_exists() {
local count_matches
# Check whether the etcd pod exists on the same node (header line included)
count_matches=$(crictl pods --label app=etcd -q | xargs -I {} crictl ps --pod {} -o json | jq -r '.containers[].metadata | select ( .name == "etcd" ).name' | wc -l)
# Check whether the etcd pod exists on the same node (including stopped/exited containers)
count_matches=$(crictl pods --label app=etcd -q | xargs -I {} crictl ps -a --pod {} -o json | jq -r '.containers[].metadata | select ( .name == "etcd" ).name' | wc -l)
Copy link
Collaborator

@clobrano clobrano Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment might be a bit clearer. Something like

Check whether the etcd pod exists on the same node (including stopped/exited containers)

if [ "$count_matches" -eq 1 ]; then
# etcd pod found
return 0
Expand Down