Replace package/ra2mdlauncher executable with batch script for transparency. #450
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| @echo off | ||
|
|
||
| :: This program is free software: you can redistribute it and/or modify | ||
| :: it under the terms of the GNU General Public License as published by | ||
| :: the Free Software Foundation, either version 3 of the License, or | ||
| :: (at your option) any later version. | ||
| :: | ||
| :: This program is distributed in the hope that it will be useful, | ||
| :: but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| :: MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| :: GNU General Public License for more details. | ||
| :: | ||
| :: You should have received a copy of the GNU General Public License | ||
| :: along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| :: This script is a launcher for Yuri's Revenge. | ||
| :: It checks if the gamemd.exe exists and its size. | ||
| :: If the size is 5 MiB or larger, it launches gamemd.exe. | ||
| :: If not, it checks for RA2MD.exe and launches it if found. | ||
| :: If not found, it launches gamemd.exe. | ||
|
|
||
| setlocal | ||
|
|
||
| set "appPath=%~dp0" | ||
| set "gameMdPath=%appPath%gamemd.exe" | ||
| set "ra2MdPath=%appPath%RA2MD.exe" | ||
| set "minSize=5242880" :: 5 MiB in bytes | ||
|
|
||
| if not exist "%gameMdPath%" ( | ||
| echo Error: gamemd.exe not found. | ||
| exit /b 2 | ||
| ) | ||
|
|
||
| for %%A in ("%gameMdPath%") do set "fileSize=%%~zA" | ||
|
|
||
| if defined fileSize ( | ||
| if "%fileSize%" GEQ "%minSize%" ( | ||
| echo Launching gamemd.exe | ||
| start "" "%gameMdPath%" | ||
| ) else ( | ||
| if exist "%ra2MdPath%" ( | ||
| echo Launching RA2MD.exe | ||
| start "" "%ra2MdPath%" | ||
| ) else ( | ||
| echo RA2MD.exe not found. Launching gamemd.exe instead. | ||
| start "" "%gameMdPath%" | ||
| ) | ||
| ) | ||
|
There was a problem hiding this comment. The original ra2mdlauncher passes through all parameters into the final exe (e.g., |
||
| ) else ( | ||
| echo Error: Unable to determine the size of gamemd.exe. | ||
| exit /b 3 | ||
| ) | ||
|
|
||
| endlocal | ||
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I can now confirm the legit version from a retail CD has the filename
Ra2md.exewhere onlyRis capital. For an Origin or FD copy I don't have access right now.Please provide a good reason changing 5000000 to 5242880.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check for every possible case then.
I assumed the size wouldn't be smaller, so I took the exact size of Steam's RA2MD.exe. However, I prefer an exact byte number, and 5 MiB is conveniently just smaller than 5,286,208 bytes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original 5000000 was selected because it was the median between a gamemd without HD icon and a gamemd with an HD icon. We should tolerate possible reduction of the file size so 5000000 is a good separator.