-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bash script for Linux, mirroring functionality of package/ra2mdlauncher executable. #451
base: develop
Are you sure you want to change the base?
Conversation
…uncher executable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions. Feel free to accept or reject them.
is_patched "$gamemd_path" | ||
is_patched_status=$? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion, in response to set -e
is_patched "$gamemd_path" | |
is_patched_status=$? | |
is_patched "$gamemd_path" && is_patched_status=0 || is_patched_status=$? |
@@ -0,0 +1,95 @@ | |||
#!/bin/bash | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion
set -euo pipefail | |
@@ -34,6 +34,7 @@ qres32.dll | |||
ls800obs.shp | |||
mplsobs.pal | |||
ra2mdlauncher.exe | |||
ra2md-launcher.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it better to make the file name consistent? I mean considering removing the hyphen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it better to make the file name consistent? I mean considering removing the hyphen
I personally prefer having readable file names. 🤔
Also I am not sure whether |
|
This is for Linux. It should run on MacOS, but it is untested.