Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bash script for Linux, mirroring functionality of package/ra2mdlauncher executable. #451

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Revival8697
Copy link

This is for Linux. It should run on MacOS, but it is untested.

Copy link
Member

@SadPencil SadPencil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Feel free to accept or reject them.

Comment on lines +78 to +79
is_patched "$gamemd_path"
is_patched_status=$?
Copy link
Member

@SadPencil SadPencil Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, in response to set -e

Suggested change
is_patched "$gamemd_path"
is_patched_status=$?
is_patched "$gamemd_path" && is_patched_status=0 || is_patched_status=$?

@@ -0,0 +1,95 @@
#!/bin/bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion

Suggested change
set -euo pipefail

@@ -34,6 +34,7 @@ qres32.dll
ls800obs.shp
mplsobs.pal
ra2mdlauncher.exe
ra2md-launcher.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better to make the file name consistent? I mean considering removing the hyphen

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better to make the file name consistent? I mean considering removing the hyphen

I personally prefer having readable file names. 🤔

@SadPencil
Copy link
Member

Also I am not sure whether .gitattributes correctly treats the line break of .sh file as LF (#449) so pay attention to this point in case you might had submitted the .sh file as CRLF (just in case; not verified).

@Revival8697
Copy link
Author

Also I am not sure whether .gitattributes correctly treats the line break of .sh file as LF (#449) so pay attention to this point in case you might had submitted the .sh file as CRLF (just in case; not verified).

YRLauncherUnix.sh was CRLF, I fixed it. Also I didn't know that git can enforce line endings, that is certainly useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants