Prepare repository for BCR release #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #37 will not alter performanceComparing Summary
|
GuillaumeLagrange
force-pushed
the
cod-1556-any-plans-for-bazel-registry
branch
14 times, most recently
from
2506554 to
634b591
Compare
Copilot finished reviewing on behalf of
GuillaumeLagrange
November 19, 2025 16:45
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the repository for publication to the Bazel Central Registry (BCR) by restructuring it into separate Bazel modules and enhancing the release process.
- Splits the monorepo into two independent modules:
codspeed_coreandcodspeed_google_benchmark_compat - Enhances the release script to create tarballs with submodule content included
- Updates all build configurations and examples to reference modules via external repository syntax
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/release.sh | Adds submodule handling and tarball creation for GitHub releases with submodule content |
| core/MODULE.bazel | New module definition for the core CodSpeed library (version 1.4.0) |
| core/BUILD | Updates version to use module_version() and adds C++17 standard flag for non-Windows builds |
| core/CMakeLists.txt | Updates version from 1.2.0 to 1.4.0 |
| google_benchmark/MODULE.bazel | Renames module from google_benchmark to codspeed_google_benchmark_compat with dependencies on codspeed_core |
| google_benchmark/BUILD.bazel | Updates dependency references to use external @codspeed_core repository and adds alias for codspeed_mode |
| MODULE.bazel | Restructures for local development with path overrides for the two modules |
| examples/google_benchmark_bazel/BUILD.bazel | Updates dependency to reference @codspeed_google_benchmark_compat |
| .bazelrc | Updates flag reference from //core:codspeed_mode to @codspeed_core//:codspeed_mode |
| .github/workflows/ci.yml | Updates all Bazel flag references to use external repository syntax |
| flake.nix | Adds git-cliff tool to development environment |
| CONTRIBUTING.md | Updates release documentation with new process and version locations |
| MODULE.bazel.lock | Updates lock file to reflect dependency changes and new module structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GuillaumeLagrange
force-pushed
the
cod-1556-any-plans-for-bazel-registry
branch
from
634b591 to
6f4b3fa
Compare
GuillaumeLagrange
force-pushed
the
cod-1556-any-plans-for-bazel-registry
branch
from
a0dc601 to
cd55ad4
Compare
std::filesystem usage requires c++17
GuillaumeLagrange
force-pushed
the
cod-1556-any-plans-for-bazel-registry
branch
from
cd55ad4 to
cccb6fc
Compare
adriencaccia
requested changes
Nov 20, 2025
GuillaumeLagrange
force-pushed
the
cod-1556-any-plans-for-bazel-registry
branch
3 times, most recently
from
8a8c313 to
c538c05
Compare
GuillaumeLagrange
force-pushed
the
cod-1556-any-plans-for-bazel-registry
branch
6 times, most recently
from
20e79d7 to
7abc45c
Compare
Member
not-matthias
left a comment
not-matthias
left a comment
There was a problem hiding this comment.
A few places that have leftover instrumentation mode. Otherwise LGTM
adriencaccia
approved these changes
Nov 21, 2025
Member
adriencaccia
left a comment
adriencaccia
left a comment
There was a problem hiding this comment.
LGTM, waiting on @not-matthias review
Github asset does not contain submodule code, we manually create the git archive with all submodules sources checked out to be used as a self contained bazel module.
GuillaumeLagrange
force-pushed
the
cod-1556-any-plans-for-bazel-registry
branch
from
7abc45c to
f23b68b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.