Skip to content

feat: add support for analysis mode #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add support for analysis mode #152

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ce0cab
feat: add memory profiling in CI
not-matthias Nov 20, 2025
5a5d450
feat: add support for analysis mode
not-matthias Nov 19, 2025
97e21d0
chore: add example with allocations
not-matthias Nov 20, 2025
8d90e07
feat(cargo-codspeed): add analysis build mode
not-matthias Nov 21, 2025
435a805
chore: bump instrument-hooks
not-matthias Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,43 @@ jobs:
mode: walltime
token: ${{ secrets.CODSPEED_TOKEN }}


compat-integration-test-memory:
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have multi-dimensional matrices, as well as some dimensions precising two things

We could combine everything in one big matrix, one dimension being the library we are testing, the other one the mode and the runner it runs on like here https://github.com/CodSpeedHQ/codspeed-cpp/blob/f23b68b27f8543f88f95ff0bdc46785733dee061/.github/workflows/ci.yml#L57-L62

WDYT ?

We could conditionnallly remove the .cargo/config.toml, as well as conditionnally skip the uploading part for memory (for now)

runs-on: ubuntu-latest
strategy:
matrix:
package:
- codspeed-divan-compat
- codspeed-divan-compat-examples
- codspeed-criterion-compat
steps:
- uses: actions/checkout@v4
with:
submodules: true
- uses: moonrepo/setup-rust@v1
with:
cache-target: release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- run: cargo install --path crates/cargo-codspeed --locked

- run: |
# Remove the cargo config else it forces instrumentation mode
rm -f .cargo/config.toml
cargo codspeed build -p ${{ matrix.package }} -m instrumentation

# TODO: Enable once we can upload it
# - name: Run the benchmarks
# uses: CodSpeedHQ/action@chore/runner-branch
# env:
# MY_ENV_VAR: "YES"
# with:
# runner-branch: cod-1670-runner-profile-memory-of-command
# run: cargo codspeed run
# mode: memory
# token: ${{ secrets.CODSPEED_TOKEN }}
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to remove secrets now with OIDC


musl-build-check:
strategy:
matrix:
Expand Down